[HOLD 2.7.0] Add pandas to nightly wheel installs #4239
Conversation
.github/workflows/gh-ci-cron.yaml
Outdated
| @@ -3,6 +3,9 @@ on: | |||
| schedule: | |||
| # 3 am Tuesdays and Fridays | |||
| - cron: "0 3 * * 2,5" | |||
| pull_request: | |||
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4239 +/- ##
==========================================
Coverage 93.62% 93.62%
==========================================
Files 179 193 +14
Lines 24199 25305 +1106
Branches 4064 4064
==========================================
+ Hits 22657 23693 +1036
- Misses 1026 1096 +70
Partials 516 516
☔ View full report in Codecov by Sentry. |
|
Logging issue happens whether or not nightly pandas is installed, looks like that's a separate isssue. |
|
Timeouts aside, this should be good to go if anyone wants to review - CI is returning green for |
There was a problem hiding this comment.
lgtm, thanks @IAlibay
(If I'm following correctly, is this something where we expect to be able come back remove pandas later, after figuring out the accidental-dependency?)
Yeah eventually, it's probably being pulled in by one of the core dependencies we've been wanting to get rid of (biopython, networkx, or matplotlib). P.S. Thanks for the review, I won't merge until we get 2.7.0 started. |
IAlibay
changed the title
Fixes #4238
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4239.org.readthedocs.build/en/4239/